Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-test.cc File be/src/runtime/decimal-test.cc: Line 635: result_scale); > this doesn't look correct when t1.precision - t1.scale + t2.scale + result_ Are you sure you didn't miss the max(6, t1.scale + t2.precision + 1) above? Otherwise looks correct to me. http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 346: DCHECK(r != 0); > Probably clearer if the last part was: Have fixed this up Line 350: DCHECK(sizeof(RESULT_T) > 8 || abs(r) <= DecimalUtil::MAX_UNSCALED_DECIMAL8); > but we may have promoted from 4 to 8. i think what you're trying to show is That is what I was trying to say. -- To view, visit http://gerrit.cloudera.org:8080/6132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bfcbe37555b74598d409c6f84f06b0ae5c4312 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
