Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/10/be/src/runtime/types.h File be/src/runtime/types.h: Line 147: int min_scale = std::min(scale, +MIN_ADJUSTED_SCALE); I decided to copy this from the Java code in the frontend as it looked useful. In the spirit of letting no good deed go unpunished, the compiler has rewarded me with the little gift of converting MIN_ADJUSTED_SCALE into an lvalue, as std::min takes its values by reference. What is our standard approach to tackling this? Provide definitions in the .cc file? (Fortunately in this cases, there is one). -- To view, visit http://gerrit.cloudera.org:8080/6132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bfcbe37555b74598d409c6f84f06b0ae5c4312 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
