Lars Volker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5891/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 510: def test_resolution_by_name(self, vector, unique_database): Good find. I grepped the codebase for this and found another occurrence. Want to fix it in this change? If not, I can fix it in a new change. Why did this even work with the parameters swapped? tests/query_test/test_mt_dop.py:46: def test_compute_stats(self, unique_database, vector) -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Nathan Salmon <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Nathan Salmon <[email protected]> Gerrit-HasComments: Yes
