Alex Behm has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5891/4/be/src/exec/parquet-metadata-utils.cc File be/src/exec/parquet-metadata-utils.cc: Line 36: using boost::algorithm::iequals; > why boost and not something like strcasecmp? Works for me. Done. -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Nathan Salmon <nathan.gsal...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nathan Salmon <nathan.gsal...@gmail.com> Gerrit-HasComments: Yes
