Lars Volker has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py ......................................................................
Patch Set 1: (1 comment) Thanks for having a look. David, please see my reply to MJ's comment. http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 46: def test_compute_stats(self, vector, unique_database): > how do we know what is the 'right' order? what happens when it's not in the The order doesn't matter, since the calls use named parameters: test...(vector=..., unique_database=...). However this is the only place in our code base where the order is different, so I thought we may as well fix it. Maybe it'll prevent a bug in the future when someone calls the method from another test or so. -- To view, visit http://gerrit.cloudera.org:8080/6228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
