Lars Volker has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py ......................................................................
Patch Set 1: (1 comment) > Sure, for the sake of consistency, I'm OK with this change. > > There are actually two places where this occurs. > > tests/query_test/test_mt_dop.py: def test_compute_stats(self, > unique_database, vector): > tests/query_test/test_scanners.py: def test_resolution_by_name(self, > unique_database, vector): The other place is addressed by Alex in this change: https://gerrit.cloudera.org/#/c/5891/ That's how I found this place to begin with. :) http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 46: def test_compute_stats(self, vector, unique_database): > ok, it's kind of misleading to call this a fix then. can you change the tex Done -- To view, visit http://gerrit.cloudera.org:8080/6228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
