Sure deal. Thank for keeping tabs and driving it over the line. Learned a good deal about the test harness, so future contributions should be more well rounded.
Happy Friday, NS On Fri, Mar 3, 2017 at 1:27 PM, Alex Behm <[email protected]> wrote: > Nathan, thanks for identifying this bug and your contribution! > > On Fri, Mar 3, 2017 at 2:20 AM, Impala Public Jenkins (Code Review) < > [email protected]> wrote: > >> Impala Public Jenkins has submitted this change and it was merged. >> >> Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. >> ...................................................................... >> >> >> IMPALA-4675: Case-insensitive matching of Parquet fields. >> >> The query option PARQUET_FALLBACK_SCHEMA_RESOLUTION >> allows matching of Parquet fields by name instead of by >> index (the default). >> >> Parquet column names are case sensitive, but Impala treats >> db/table/column/field names as case-insensitive. Today, >> there is no way today to select Parquet columns with mixed >> casing via SQL using the name-based field resolution policy. >> >> This patch changes the matching of Parquet fields to be >> case-insensitive. >> >> Testing: >> - Modified the data files backing complextypestbl >> to contain fields with mixed casing. >> - Several existing tests run against this table, >> including the test for name-based resolution. >> - I confirmed that without this fix, the existing >> name-based resolution tests fail on the modified >> data files. >> - I locally ran test_scanners.py and test_nested_types.py >> on exhaustive with this fix. >> >> Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4 >> Reviewed-on: http://gerrit.cloudera.org:8080/5891 >> Reviewed-by: Alex Behm <[email protected]> >> Tested-by: Impala Public Jenkins >> --- >> M be/src/exec/parquet-metadata-utils.cc >> M be/src/exec/parquet-metadata-utils.h >> M testdata/ComplexTypesTbl/nonnullable.avsc >> M testdata/ComplexTypesTbl/nonnullable.json >> M testdata/ComplexTypesTbl/nonnullable.parq >> M testdata/ComplexTypesTbl/nullable.avsc >> M testdata/ComplexTypesTbl/nullable.json >> M testdata/ComplexTypesTbl/nullable.parq >> M testdata/workloads/functional-query/queries/QueryTest/parque >> t-resolution-by-name.test >> M tests/query_test/test_scanners.py >> 10 files changed, 71 insertions(+), 76 deletions(-) >> >> Approvals: >> Impala Public Jenkins: Verified >> Alex Behm: Looks good to me, approved >> >> >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/5891 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: merged >> Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4 >> Gerrit-PatchSet: 7 >> Gerrit-Project: Impala-ASF >> Gerrit-Branch: master >> Gerrit-Owner: Nathan Salmon <[email protected]> >> Gerrit-Reviewer: Alex Behm <[email protected]> >> Gerrit-Reviewer: Impala Public Jenkins >> Gerrit-Reviewer: Lars Volker <[email protected]> >> Gerrit-Reviewer: Marcel Kornacker <[email protected]> >> Gerrit-Reviewer: Michael Brown <[email protected]> >> Gerrit-Reviewer: Nathan Salmon <[email protected]> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "impala-cr" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/a/cloudera.com/d/optout >> . >> > >
