Lars Volker has posted comments on this change. Change subject: IMPALA-4734: Set parquet::RowGroup::sorting_columns ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6219/2/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: Line 1060: sorting_column.column_idx = col_idx; > this is an index into parquet.RowGroup.columns, but you're populating that I think this is safe, since we control the order of the columns here, and interpreting their position like that is a common pattern in this file, e.g. in Init(). Should I add a comment to explain this here? -- To view, visit http://gerrit.cloudera.org:8080/6219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42aab585e9e627796e9510e783652d49d74b56c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
