Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4734: Set parquet::RowGroup::sorting_columns ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6219/2/fe/src/main/java/org/apache/impala/planner/TableSink.java File fe/src/main/java/org/apache/impala/planner/TableSink.java: Line 92: * forwarded to the backend to populate the RowGroup::sorting_columns list in parquet no need to comment on intention of backend here Line 97: boolean overwrite, boolean inputIsClustered, List<Integer> sortByColumns) { also add notnull checks for the lists, then -- To view, visit http://gerrit.cloudera.org:8080/6219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42aab585e9e627796e9510e783652d49d74b56c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
