Tim Armstrong has posted comments on this change. Change subject: IMPALA-4929: Safe concurrent access to IR function call graph ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6326/1/be/src/codegen/codegen-callgraph.cc File be/src/codegen/codegen-callgraph.cc: Line 87: call_graph_[key].insert(fn_name); > The entry may not exist already. Note the entry creation above is for 'fn_n Ah got it http://gerrit.cloudera.org:8080/#/c/6326/2/be/src/codegen/codegen-callgraph.cc File be/src/codegen/codegen-callgraph.cc: PS2, Line 71: <std: std:: not needed. http://gerrit.cloudera.org:8080/#/c/6326/1/be/src/codegen/codegen-callgraph.h File be/src/codegen/codegen-callgraph.h: Line 21: #include <boost/unordered_map.hpp> > Good point but it appears that two closely related files llvm-codegen.cc an I believe the std:: and boost:: versions have different perf characteristics because the c++ standard has some restrictions around how iterators behave. So they might not be a simple drop-in replacement. E.g. https://tinodidriksen.com/2010/04/cpp-set-performance/ -- To view, visit http://gerrit.cloudera.org:8080/6326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acd6bad80341121c8189d817e0fe62f2862f28a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
