Michael Ho has posted comments on this change. Change subject: IMPALA-4929: Safe concurrent access to IR function call graph ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6326/2/be/src/codegen/codegen-callgraph.cc File be/src/codegen/codegen-callgraph.cc: PS2, Line 71: std:: > std:: not needed. Done http://gerrit.cloudera.org:8080/#/c/6326/2/be/src/codegen/codegen-callgraph.h File be/src/codegen/codegen-callgraph.h: Line 57: CallGraph call_graph_; > Maybe this is a bit overkill, but moving this (and the Init() function) to Thanks for the idea. The public interfaces of this class: GetCallees() and fns_referenced_by_gv() both have const attribute in their return type so it should get most of what we need for preventing mutation outside of the class. Of course, one can always do const_cast() but I guess we should catch them in code review. The bool inited_ will catch re-initialization of the map as this should not occur. -- To view, visit http://gerrit.cloudera.org:8080/6326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acd6bad80341121c8189d817e0fe62f2862f28a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
