Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 229: Status AdmissionController::Init(StatestoreSubscriber* subscriber) { I'm worried about this approach for admission control. This will work when num coordinators = 1, but will not work otherwise. The issue is that there are 2 accounting mechanisms for tracking resources, one is per-coordinator and works perfectly with 1 coordinator, but otherwise resource stats are accumulated from all *backends*. Is this flag meant to be used with multiple coordinators or just 1? -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
