Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: Line 228: if (FLAGS_use_statestore && statestore_port > 0) { > please move all of the duplicated code, incl. initializer list, into a shar This is a good idea - but please leave it for now, as one of the KRPC commits would conflict significantly with this. Maybe file a JIRA to clean this up (pretty sure we can remove the second c'tor). -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
