Dan Hecht has posted comments on this change. Change subject: IMPALA-4631: avoid DCHECK in PlanFragementExecutor::Close(). ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6375/1//COMMIT_MSG Commit Message: PS1, Line 9: 1 > Or should we just skip this DCHECK altogether in a EC2 VM ? We don't know for sure it is dependent on EC2 VMs, and EC2 is where we get the bulk of our testing during development so I'd like to leave it. And it would be good to know if the new dcheck ever fires. PS1, Line 11: CLOCK_MONOTONICs_COARSE > CLOCK_MONOTONIC_COARSE Done PS1, Line 14: losen > loosen ? Done http://gerrit.cloudera.org:8080/#/c/6375/1/be/src/runtime/plan-fragment-executor.cc File be/src/runtime/plan-fragment-executor.cc: Line 516: // TODO: IMPALA-4631: Occasionally we see other_time = total_time + 1 for some reason > consider logging so we can start identifying trends when this happens without instrumenting the scoped timer code itself (which I'll probably do but as a private build), I don't think we can get more info than we already have from the core files, so I think I'll avoid adding more logging. -- To view, visit http://gerrit.cloudera.org:8080/6375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9883fdb1be6a4301864da85da56ec96f4dafbe7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
