Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4631: avoid DCHECK in PlanFragementExecutor::Close(). ......................................................................
IMPALA-4631: avoid DCHECK in PlanFragementExecutor::Close(). Occasionally, we see other_time == total_time+1 for some reason we don't yet understand. We've only seen this on EC2 and with CLOCK_MONOTONIC_COARSE, so it could be that clock occasionally goes backwards. The intent of the DCHECK is to verify that we didn't miss accounting entire intervals of time, so let's loosen it slightly to avoid this "false" positive. Change-Id: Ia9883fdb1be6a4301864da85da56ec96f4dafbe7 Reviewed-on: http://gerrit.cloudera.org:8080/6375 Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/plan-fragment-executor.cc 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9883fdb1be6a4301864da85da56ec96f4dafbe7 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]>
