Joe McDonnell has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 21: #include <kudu/client/client.h> > it would be really nice if we could avoid including the kudu header here. I I'm looking into this. The sp::shared_ptr type comes from the KuduClientBuilder::Build call in CreateKuduClient. I think it is not guaranteed to be safe for us to transfer something from a shared_ptr to unique_ptr. There is no way for us to tell if this is the only shared_ptr to that object. -- To view, visit http://gerrit.cloudera.org:8080/6312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e4593300e376bc508b78acaea64ffdd2c73a67a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
