Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/exec/kudu-scan-node-base.cc File be/src/exec/kudu-scan-node-base.cc: Line 105: KUDU_RETURN_IF_ERROR(client_->OpenTable(table_desc->table_name(), &table_), does this need to be done query-wide? how much data/work sits behind this call? http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/exec/kudu-scan-node-base.h File be/src/exec/kudu-scan-node-base.h: Line 75: const TupleDescriptor* tuple_desc() const { return tuple_desc_; } functions, even getters, at bottom Line 79: kudu::client::KuduClient *client_; formatting Line 80: kudu::client::KuduClient* kudu_client() { return client_; } also move down Line 82: /// Kudu table reference. Shared between scanner threads. between scanner threads of KuduScanNode? http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 119: kudu::client::KuduClient **client); who owns this? -- To view, visit http://gerrit.cloudera.org:8080/6312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e4593300e376bc508b78acaea64ffdd2c73a67a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
