Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6037/7/be/src/runtime/data-stream-partitioner.cc File be/src/runtime/data-stream-partitioner.cc: PS7, Line 51: KuduTableDescriptor* table_desc_ = static_cast<KuduTableDescriptor*>(table_desc); : sp::shared_ptr<KuduClient> client_; : RETURN_IF_ERROR(CreateKuduClient(table_desc_->kudu > probably a codegen opportunity here for later, can you leave a TODO? Done http://gerrit.cloudera.org:8080/#/c/6037/7/be/src/runtime/data-stream-partitioner.h File be/src/runtime/data-stream-partitioner.h: PS7, Line 45: // partition number as parameters. : // TODO: make this cleaner without sacrifi > I'm sorry if I wasn't clear when we spoke last, but I think it is still bet Done PS7, Line 63: > typo Done PS7, Line 87: ++next_unknow > rename to indicate used for R.R. only, e.g. next_unknown_partition_ or some Done -- To view, visit http://gerrit.cloudera.org:8080/6037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10b3295159354888efcde3df76b0edb24161515 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
