Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-partitioner.h File be/src/runtime/data-stream-partitioner.h: PS8, Line 62: KuduStreamPartitioner add some class-level comments here and to the HashPartitioner, e.g. call out that this one calls into the Kudu API to perform the partitioning PS8, Line 71: const T& cb it sounds like you'll go back to the prev strategy (no lambda), but I'll mention this anyway: this would deserve a good name and comment because it's not clear what this is, even reading the code below http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File be/src/runtime/data-stream-sender.cc: Line 462: default: you can add a dcheck here to crash the process. this shouldn't happen unless we have a bug. -- To view, visit http://gerrit.cloudera.org:8080/6037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10b3295159354888efcde3df76b0edb24161515 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
