Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/2/source/gflags/build.sh File source/gflags/build.sh: PS2, Line 33: if [ -e CMakeLists.txt ]; then : wrap cmake -DBUILD_STATIC_LIBS=ON -DCMAKE_INSTALL_PREFIX=$LOCAL_INSTALL -DCMAKE_BUILD_TYPE=RELEASE : else : wrap ./configure --with-pic --prefix=$LOCAL_INSTALL > I assume the CMakeLists.txt path is for the newer version? I think it'd be Would prefer not to use PACKAGE_VERSION, as I find version checking in bash to be pretty error-prone (at least with my skill level in bash). I added a comment to clarify. -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 Gerrit-PatchSet: 2 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
