Tim Armstrong has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/3/source/gflags/build.sh File source/gflags/build.sh: Line 40: CFLAGS="-fPIC -DPIC" wrap make -j${BUILD_THREADS:-4} install The CFLAGS needs some explanation - this is to force CMake to build static libraries with PIC? It would be nice to do it in a more direct way but googling indicates there may not be a nice way to achieve this. -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
