Henry Robinson has posted comments on this change. Change subject: IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior ......................................................................
Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6333/2//COMMIT_MSG Commit Message: PS2, Line 7: Calling AuthManager::Init() more than once results in undefined behavior Nit picking further: "Allow AuthManager::Init() to be called more than once" http://gerrit.cloudera.org:8080/#/c/6333/2/be/src/rpc/authentication.h File be/src/rpc/authentication.h: PS2, Line 42: running objects don't run, they have lifetime. So maybe "AuthManager should be treated like a singleton, and only instantiated once.". PS2, Line 43: a second time more than once -- To view, visit http://gerrit.cloudera.org:8080/6333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
