Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5041: Allow AuthManager::Init() to be called more than once ......................................................................
Patch Set 3: Code-Review+2 (3 comments) Thanks for the review! Carry +2. http://gerrit.cloudera.org:8080/#/c/6333/2//COMMIT_MSG Commit Message: PS2, Line 7: Allow AuthManager::Init() to be called more than once > Nit picking further: "Allow AuthManager::Init() to be called more than once Done http://gerrit.cloudera.org:8080/#/c/6333/2/be/src/rpc/authentication.h File be/src/rpc/authentication.h: PS2, Line 42: instant > objects don't run, they have lifetime. So maybe "AuthManager should be trea Done PS2, Line 43: more than onc > more than once Done -- To view, visit http://gerrit.cloudera.org:8080/6333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
