Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6261
to look at the new patch set (#8).
Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT
......................................................................
IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT
Create external table can be used for two different operations,
creating a new managed table, and importing an existing unmanaged
external table. Previously, it was only possible to create managed
external tables with CTAS for Kudu. This change makes it possible
to create new, unmanaged external kudu tables from SELECT statements.
This is useful for importing data from one table to another persistent
table in Kudu.
In the catalog executor, we detect if a table creation is new by
inferring that from the presence of column definitions, not by whether
it is external / managed. Front-end code is changed to allow this
through the parser. This means any attempts to specify table metadata
for Kudu tables are interpreted as a table creation.
Testing: Manual testing, expanded ParserTest and AnalyzeDDLTest
and added test cases to query_test to validate Kudu support.
Ran the folowing query:
create external table test2_name primary key(id) partition by hash(id)
partitions 10 stored as kudu as select * from test_name;
Which successfully created and inserted 3 rows of data. Tried many
other things like changing primary keys and forms of partitioning.
Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M shell/impala_shell.py
M tests/query_test/test_kudu.py
8 files changed, 92 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/6261/8
--
To view, visit http://gerrit.cloudera.org:8080/6261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
