Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6261/7//COMMIT_MSG Commit Message: Line 10: new by inferring that from the presence of column definitions, not > what does 'if a table creation is new' mean? New rather that existing table. Terminology here is confusing, as managed != external, yet in many places of code and documentation, that is implied. Will rephrase. http://gerrit.cloudera.org:8080/#/c/6261/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 2264: "tblproperties('kudu.table_name'='t')", "Table partitioning must be " + > why is that? wouldn't the kudu table/metadata be able to provide that? Specifying any part of the metadata (x int) now implies a table creation, as we use the presence of column definitions to infer that this is a table creation. Since the assumption is that the table is being created, we need to know the partitioning scheme to create it. I tried to make the error message suggest this. I'll add a positive test case to illustrate the required syntax. http://gerrit.cloudera.org:8080/#/c/6261/6/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS6, Line 360: kudu_tbl_name = KuduTestSuite.to_kudu_table_name(unique_database, "foo2") : assert kudu_client.table_exists(kudu_tbl_name) : cursor.execute("SELECT * FROM %s.foo2" % (unique_database)) : assert len(cursor.fetchall()) == 1 : cursor.execute("DROP TABLE %s.foo2" % (unique_database)) : assert kudu_client.table_exists(kudu_tbl_name) > foo2 in kudu won't be deleted when you drop the database in impala though, Good point. -- To view, visit http://gerrit.cloudera.org:8080/6261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
