Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 294: > 2 spaces Done http://gerrit.cloudera.org:8080/#/c/5715/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 150: # Kudu flags > please add why these are specified or where they came from Done PS1, Line 292: maintenance_manager_proto > can this be linked in kudu_util so it doesn't have to bleed in here? it's c Fixed. http://gerrit.cloudera.org:8080/#/c/5715/1/be/src/kudu/util/CMakeLists.txt File be/src/kudu/util/CMakeLists.txt: PS1, Line 185: # version_info.cc TODO(KRPC): Consider re-adding > why? remove the stub file if we don't compile it I think removing the stub would be annoying for future updates to this directory - it would just creep back in. -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
