Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node.h File be/src/exec/union-node.h: PS1, Line 71: tuple_pool_; FWIW, this is probably not needed in the future as we avoid baking pointers into generated IR. Looks like I missed this one case in Tuple::CodegenMaterializeExprs(). -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
