Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/2/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: PS2, Line 23: void UnionNode::MaterializeExprsInner(const vector<ExprContext*>& exprs, : TupleRow* row, Tuple* dst_tuple, MemPool* pool) { This seems like a thin-wrapper around Tuple::MaterializeExprs(). It seems unnecessary to cross-compile this function anymore. How about we just call the compiled IR function directly ? http://gerrit.cloudera.org:8080/#/c/6459/2/be/src/exec/union-node.cc File be/src/exec/union-node.cc: PS2, Line 184: codegend_union_materialize_exprs_fns_.size() == 0 Would it be simpler to always initialize all entries of codegend_union_materialize_exprs_fns_ to nullptr ? Simpler logic is beneficial as this seems to be the critical path of union node. PS2, Line 190: DCHECK( DCHECK_LT -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
