Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6468/1/buildall.sh File buildall.sh: PS1, Line 270: master it would be better to use the same version as below, but just build_fake_package as we do if it's not a 'supported platform'. A cleaner solution would just be to modify 'is_supported_platform' to return false if ppc64le http://gerrit.cloudera.org:8080/#/c/6468/1/source/kudu/build.sh File source/kudu/build.sh: Line 68: Can you remove the build changes for now since it sounds like this is still a WIP and you'll be building the 'fake package'? PS1, Line 70: git clone https://github.com/ibmsoe/kudu The Kudu changes will be merged into upstream Kudu master, right? PS1, Line 121: echo "Installing gcc-4.9.3 to build kudu src code on ppc" : source $SOURCE_DIR/source/kudu/setup_gcc493.sh why do you need a different version of gcc to build kudu but not for other packages? i.e. why can't you just use this version of gcc for the entire toolchain (see GCC_VERSION in init.sh ) http://gerrit.cloudera.org:8080/#/c/6468/1/source/kudu/kudu-config.sh File source/kudu/kudu-config.sh: this file is misleading because it's specific to the ppc build. regardless, it looks to me like you're not building kudu yet from buildall.sh which calls build_fake_package, so it'd be better to remove this for now -- To view, visit http://gerrit.cloudera.org:8080/6468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Valencia Edna Serrao <vser...@us.ibm.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
