Dan Hecht has posted comments on this change. Change subject: IMPALA-5113: fix dirty unpinned invariant ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool-internal.h File be/src/runtime/bufferpool/buffer-pool-internal.h: PS2, Line 123: buffer buffer from a clean page? Should it also be plural, since we might have to reclaim multiple buffers if the new buffer is larger, right? PS2, Line 178: . ... given our choice of eviction policy. http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: PS2, Line 640: bug could say IMPALA-5113 http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool.cc File be/src/runtime/bufferpool/buffer-pool.cc: PS2, Line 446: Make sure that we have enough space in the reservation these comments seem confusing to me because we aren't freeing up reservation. maybe something like: Enforce the eviction policy. We may need to evict a page in order to repin this one. Line 467: // Make sure that we have enough space in the reservation to do so. similar -- To view, visit http://gerrit.cloudera.org:8080/6469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e08acb6cf6839bfccbd09258c093b1c8252b25 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
