Tim Armstrong has posted comments on this change. Change subject: IMPALA-5113: fix dirty unpinned invariant ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool-internal.h File be/src/runtime/bufferpool/buffer-pool-internal.h: PS2, Line 123: buffer > buffer from a clean page? Done PS2, Line 178: . > ... given our choice of eviction policy. Done http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: PS2, Line 640: bug > could say IMPALA-5113 Done http://gerrit.cloudera.org:8080/#/c/6469/2/be/src/runtime/bufferpool/buffer-pool.cc File be/src/runtime/bufferpool/buffer-pool.cc: PS2, Line 446: Make sure that we have enough space in the reservation > Or maybe "We may need to clean some pages ..." Done Line 456: dirty_unpinned_bytes_ -= page->len; I found a bug here while testing on another branch - we don't bumb the counter correctly. I was able to reproduce it on this branch with buffered-tuple-stream-v2-test by adding some additional DCHECKs. Line 467: // Make sure that we have enough space in the reservation to do so. > similar Done -- To view, visit http://gerrit.cloudera.org:8080/6469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e08acb6cf6839bfccbd09258c093b1c8252b25 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
