Tim Armstrong has posted comments on this change. Change subject: IMPALA-4701: make distcc work reliably with clang ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6493/1/bin/distcc/distcc.sh File bin/distcc/distcc.sh: Line 31: DIR=$(dirname "$0") > Maybe this should go in ""? It shouldn't be necessary - the RHS of an assignment isn't subject to expansion in the same way as other places. Line 50: CMD= > initialize to ccache? See the below comment Line 53: CMD="distcc ccache" > Are we sure this is the right order of commands? Does this script support u This enables use of ccache on the distcc servers. Ccache on the local machine is enabled in be/CMakeLists.txt independent of distcc by using RULE_LAUNCH_* to prefix "ccache" to the whole thing. So essentially when ccache and distcc are enabled we run "ccache distcc.sh", the distcc.sh runs "distcc ccache" to get two layers of caching. http://gerrit.cloudera.org:8080/#/c/6493/1/bin/distcc/distcc_env.sh File bin/distcc/distcc_env.sh: Line 74: : ${IMPALA_USE_DISTCC=} > I'm not sure I fully understand how to use this. Is this a variable that a This is usually changed by switch_compiler. I think the rename makes sense to me. http://gerrit.cloudera.org:8080/#/c/6493/1/cmake_modules/toolchain.cmake File cmake_modules/toolchain.cmake: Line 33 Didn't mean to remove this. -- To view, visit http://gerrit.cloudera.org:8080/6493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
