Tim Armstrong has posted comments on this change. Change subject: IMPALA-4701: make distcc work reliably with clang ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6493/5/bin/distcc/distcc.sh File bin/distcc/distcc.sh: Line 19: > Would it make sense to add "set -euo pipefail" here? Done http://gerrit.cloudera.org:8080/#/c/6493/5/bin/distcc/distcc_env.sh File bin/distcc/distcc_env.sh: Line 83: IMPALA_COMPILER_CONFIG_FILE="$IMPALA_HOME/.impala_compiler_opts" I ran into some issues locally because the old opts file wasn't compatible with the changed script. So I just removed Line 120: -not -path '*thirdparty*' | xargs rm -rf While I'm here, this wasn't updated to take into account the toolchain -- To view, visit http://gerrit.cloudera.org:8080/6493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
