Tim Armstrong has posted comments on this change. Change subject: IMPALA-5113: fix dirty unpinned invariant ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6469/5/be/src/runtime/bufferpool/buffer-pool-internal.h File be/src/runtime/bufferpool/buffer-pool-internal.h: Line 270: Status CleanPages(int64_t len); > do we still need the unlocked version? You're right, we only need CleanPagesLocked(). Renamed it to CleanPages and updated the comments. http://gerrit.cloudera.org:8080/#/c/6469/5/be/src/runtime/bufferpool/buffer-pool.cc File be/src/runtime/bufferpool/buffer-pool.cc: PS5, Line 506: allocate > allow? Done -- To view, visit http://gerrit.cloudera.org:8080/6469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e08acb6cf6839bfccbd09258c093b1c8252b25 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
