Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6498
Change subject: Port BufferedBlockMgr tests to buffer pool ...................................................................... Port BufferedBlockMgr tests to buffer pool BufferedBlockMgr had a number of interesting backend tests that are still relevant to BufferPool. This commit copies them across and adapts them to BufferPool. This should bring the backend test coverage for BufferPool up to par with BufferedBlockMgr. Many tests weren't ported because they are not relevant or would duplicate other tests: * GetNewBlock* -> covered by PageCreation/BufferAllocation * Pin -> covered by Pin * Deletion/DeleteSingleBlocks -> all BufferPool tests cover deletion * Close -> BufferPool doesn't have "cancellation" * TransferBufferDuringWrite -> the API being tested is not present. Some of the deletion tests are the closest analogue. * WriteCompleteWithCancelledRuntimeState -> not relevant, BufferPool doesn't reference RuntimeState. * MultipleClients* -> we have many tests for the (very different) reservation mechanism * ClientOversubscription -> oversubscription is not supported * CreateDestroyMulti -> we don't support creation/destruction of buffer pools like this * AllocationErrorHandling -> redundant with WriteErrorBlacklist Change-Id: Ifb0221e8bea6f3b23b62d5094634d97562295ea3 --- M be/src/runtime/bufferpool/buffer-allocator.h M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h 5 files changed, 819 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/6498/1 -- To view, visit http://gerrit.cloudera.org:8080/6498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb0221e8bea6f3b23b62d5094634d97562295ea3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
