Dan Hecht has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6498/6/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: PS6, Line 1434: flushing heuristic does not eagerly start writes when there are no : // disks. which path in WriteDirtyPagesAsync() is this? Line 1479: IMPALA_ASSERT_DEBUG_DEATH(pool->Unpin(&client, &pages[0]), ""); just to confirm, this is the DCHECK_EQ(0, dirty_unpinned_bytes_); in WriteDirtyPagesAsync()? http://gerrit.cloudera.org:8080/#/c/6498/5/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: PS5, Line 274: tus err_status(TErrorCode::SCRATCH_ALLOCATION_FAILED); : for (Status& err : scratch_errors_) err_status.Merg isn't that still the case? will we want to update this message still when 4697 is addressed? http://gerrit.cloudera.org:8080/#/c/6498/6/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: Line 358: LOG(INFO) << "Allocated in " << tmp_file->path(); did you mean to keep this? -- To view, visit http://gerrit.cloudera.org:8080/6498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0221e8bea6f3b23b62d5094634d97562295ea3 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
