Lars Volker has posted comments on this change. Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db ......................................................................
Patch Set 1: (1 comment) I left some comments, but I understood from the JIRA that Bharath already has a change that he's currently testing in a private ASAN run on Jenkins. Bharath, do you want to push your change for public review? http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: Line 676: char *filestr = strdup(path.string().c_str()); I think you don't need the strdup(), it should be sufficient to keep "path" around as long as filestr is accessed. A nit: we usually put the * next to the type: char* foo -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
