Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db ......................................................................
IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by .string goes out of scope immediately after being created. Also, the API to mkstemp is unclear on whether it modifies the string in place. Just strdup() the c_str() to be safe - this is not performance critical code. Testing: ASAN build, running expr-test be test; ASAN fails before, passes after this change. Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d --- M be/src/exprs/timezone_db.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/6503/2 -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]>
