Marcel Kornacker has posted comments on this change. Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). ......................................................................
Patch Set 1: (1 comment) I'm going to do a perf run to make sure this doesn't regress anything. http://gerrit.cloudera.org:8080/#/c/6511/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 596: llvm::Value* SlotDescriptor::CodegenIsNull( i found the code hard to read with the unqualified llvm types. -- To view, visit http://gerrit.cloudera.org:8080/6511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f765048f36b9e596aeb4e4482d38b94f5ffba06 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
