Tim Armstrong has posted comments on this change. Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). ......................................................................
Patch Set 1: Code-Review+1 I doubt there will be a measurable perf impact, it's very cheap compared to optimising whatever code we generated. StructType::get() uniques the type internally so the result of this function should be always equivalent. I don't feel strongly about the qualified/unqualified LLVM types, but I'll give a chance for others to weigh in. I can probably just +2 after the perf run completes if noone else has an opinion. -- To view, visit http://gerrit.cloudera.org:8080/6511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f765048f36b9e596aeb4e4482d38b94f5ffba06 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
