Tim Armstrong has posted comments on this change. Change subject: IMPALA-5127: Add history_max option ......................................................................
Patch Set 2: (1 comment) Thanks, this will be very handy. What do you think about also bumping up the default value? I suspect most people won't think to change the config but might benefit from a longer history. We should also make sure to document this in docs/topics/impala_shell_options.xml. http://gerrit.cloudera.org:8080/#/c/6335/2/shell/impala_shell.py File shell/impala_shell.py: Line 183: self.readline.set_history_length(int(options.history_max)) It would be nice to produce a human-friendly error message. I get the following, which hints at the problem but has a lot of noise: tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ impala-shell.sh Starting Impala Shell without Kerberos authentication Traceback (most recent call last): File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 1382, in <module> shell = ImpalaShell(options) File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 183, in __init__ self.readline.set_history_length(int(options.history_max)) ValueError: invalid literal for int() with base 10: '1000000k' -- To view, visit http://gerrit.cloudera.org:8080/6335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf65bbecb8fd7f1105aac62b6745d6125a603d7f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
