Zach Amsden has posted comments on this change. Change subject: IMPALA-5127: Add history_max option ......................................................................
Patch Set 2: (1 comment) I made this a bit more friendly and tolerant as well. http://gerrit.cloudera.org:8080/#/c/6335/2/shell/impala_shell.py File shell/impala_shell.py: Line 183: self.readline.set_history_length(int(options.history_max)) > It would be nice to produce a human-friendly error message. I get the follo Done -- To view, visit http://gerrit.cloudera.org:8080/6335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf65bbecb8fd7f1105aac62b6745d6125a603d7f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
