Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6389/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: Line 72: customRewriter_ = null; This was an unexpected wrinkle that made things awkward. http://gerrit.cloudera.org:8080/#/c/6389/10/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 996: info = new SlotInfo(it.nextIndex() - 1); lol I forgot to put it in the map. Worked out of the box after that. Still needs some minor changes (this step only runs after successful constant propagation), but also should run even if no propagation is done. -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
