Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views ......................................................................
Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/6389/13/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 36: import org.apache.impala.common.Pair; Actually unused, will remove http://gerrit.cloudera.org:8080/#/c/6389/13/fe/src/main/java/org/apache/impala/planner/ValueRange.java File fe/src/main/java/org/apache/impala/planner/ValueRange.java: Line 67: public boolean incorporatePredicate(BinaryPredicate.Operator op, Expr bound) { I supposed we should remove this code and add it back in a later diff (when it can actually be tested). http://gerrit.cloudera.org:8080/#/c/6389/13/testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test: Line 116: 01:AGGREGATE [FINALIZE] typo -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
