Lars Volker has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs ......................................................................
Patch Set 2: (3 comments) nit: the line wrapping could be improved in several of the places. I commented on a few but there are more. http://gerrit.cloudera.org:8080/#/c/6487/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: Line 230: // IMPALA-3570 nit: This should fit on the previous line now. http://gerrit.cloudera.org:8080/#/c/6487/2/shell/shell_output.py File shell/shell_output.py: Line 40: # Reference: IMPALA-116 nit: this should fit on the previous line now. http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/compute-table-stats.sh File testdata/bin/compute-table-stats.sh: Line 28: # IMPALA-4346 nit: this could go on a single line now. -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
