Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs ......................................................................
Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: Line 38: # TODO: We need a better way of managing how these get set. See IMPALA-4346 > nit: single line? Done Line 185: # Force load the dataset if we detect a schema change. > nit: single line? Done Line 345: ${IMPALA_HOME}/testdata/bin/lzo_indexer.sh /test-warehouse > nit: single line? Done Line 418: # the local filesystem requires the x permission (while on HDFS it requires the r > nit: single line? Done http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 837: # This can be remove if https://github.com/cloudera/impyla/pull/142 is merged. > nit: single line? Done http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/discrepancy_searcher.py File tests/comparison/discrepancy_searcher.py: Line 193: elif isinstance(test_val, float) \ > nit: single line? Done Line 198: comparison_result.test_row = test_row > nit: single line? Done http://gerrit.cloudera.org:8080/#/c/6487/2/tests/custom_cluster/test_kudu_not_available.py File tests/custom_cluster/test_kudu_not_available.py: Line 47: self.assert_failure("SELECT * FROM tinytable", cursor) > nit: single line? Done http://gerrit.cloudera.org:8080/#/c/6487/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: Line 904: if "memory limit exceeded" in caught_msg or \ > nit: single line? Done -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
