Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes ......................................................................
Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/6389/16/testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test: Line 245: (coalesce(NULL, T.int_col) + random() * T.tinyint_col = 100 OR > It is fixable. I think this is because the resulting Expr ends up with no Agree we can address the issue if we want to. I suggest we leave for now because the fix is possibly invasive and the gain is minimal. It's also unrelated to your change. Line 335: 00:SCAN HDFS [functional.alltypes] > bool_col = null is stripped from conjunct evaluation. bool_col IS null is I think this is a minor oversight in optimizeConjuncts(). If one of the conjuncts becomes NULL, then it has the same as a FALSE literal, but in that case optimizeConjuncts() will return true. -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
