Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes ......................................................................
Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/6389/16/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 749: // conjuncts because NULLs are handled differently for CompoundPredicate.AND This is the comment to which I was referring. http://gerrit.cloudera.org:8080/#/c/6389/16/testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test: Line 245: (coalesce(NULL, T.int_col) + random() * T.tinyint_col = 100 OR > Agree we can address the issue if we want to. I suggest we leave for now be I am terrified at how invasive that diff could become. Totally agree it should be in another change. Line 335: 00:SCAN HDFS [functional.alltypes] > I think this is a minor oversight in optimizeConjuncts(). If one of the con Easy fix, will check to make sure this is consistent with existing behavior. -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
