Dan Hecht has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6442/2/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: Line 110: /// false. can you concisely explain what V is? Line 133: /// put the element, returns false. same here -- To view, visit http://gerrit.cloudera.org:8080/6442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1791870576cb269e86495034f92555de48f92f10 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
