Dan Hecht has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6442/3/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: PS3, Line 134: Rvalues are moved into the queue, lvalues are : /// copied > Yes, it does. The same comment is on line 108-109. ah missed that since it's in a different ordering with the explanation of return values. this is fine. -- To view, visit http://gerrit.cloudera.org:8080/6442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1791870576cb269e86495034f92555de48f92f10 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
